linux-kernel - Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87czlwcfav.fsf@meer.lwn.net>
Date:   Thu, 16 Dec 2021 16:15:20 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Marco Elver <elver@...gle.com>,
        Harinder Singh <sharinder@...gle.com>
Cc:     davidgow@...gle.com, brendanhiggins@...gle.com, shuah@...nel.org,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tim.Bird@...y.com
Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture

Marco Elver <elver@...gle.com> writes:

> In response to the other email: Adding binary blobs just creates
> problems, for comparing different versions, and general bloating the
> whole repo, where better alternatives exist.
>
> I suppose an ASCII diagram is a bit primitive. :-)
>
> However, SVG files on the other hand are not binary blobs, they are
> text-markup based (XML), and e.g. diffing them often provides useful
> information about what changed. SVG also has the benefit of being
> vector graphics, and not being limited to one resolution.
>
> Looking at the diagram you added, I think this can easily be turned
> into vector graphics, and most likely will not use up 24KiB as a
> result.

I agree with all of this; we shouldn't be adding binary images to the
docs, and we've decided at other times that SVG is generally the best
compromise there.

Thanks, Marco, for pointing this out and producing an alternative.

Once this is all settled, do you want it to go through the docs tree?

jon