linux-kernel - Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 10:26:49 +0530
From:   Harinder Singh <sharinder@...gle.com>
To:     Jonathan Corbet <corbet@....net>
Cc:     Marco Elver <elver@...gle.com>, David Gow <davidgow@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tim.Bird@...y.com
Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture

Hello Jonathan and Marco,


On Fri, Dec 17, 2021 at 4:45 AM Jonathan Corbet <corbet@....net> wrote:
>
> Marco Elver <elver@...gle.com> writes:
>
> > In response to the other email: Adding binary blobs just creates
> > problems, for comparing different versions, and general bloating the
> > whole repo, where better alternatives exist.
> >
> > I suppose an ASCII diagram is a bit primitive. :-)
> >
> > However, SVG files on the other hand are not binary blobs, they are
> > text-markup based (XML), and e.g. diffing them often provides useful
> > information about what changed. SVG also has the benefit of being
> > vector graphics, and not being limited to one resolution.
> >
> > Looking at the diagram you added, I think this can easily be turned
> > into vector graphics, and most likely will not use up 24KiB as a
> > result.
>
> I agree with all of this; we shouldn't be adding binary images to the
> docs, and we've decided at other times that SVG is generally the best
> compromise there.
>
I did not realize that .SVG is in XML format and preferred over .PNG.
Thanks for pointing this out. I replaced .SVG with .PNG.

> Thanks, Marco, for pointing this out and producing an alternative.
>
A big thanks to Marco for creating  this .SVG file for the documentation :-)

> Once this is all settled, do you want it to go through the docs tree?
>
Yeah! that's the plan.

> jon
Thanks,
Harinder Singh