linux-kernel - Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tuf9vso3.wl-maz@kernel.org>
Date:   Thu, 16 Dec 2021 08:51:40 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Qin Jian <qinjian@...lus1.com>
Cc:     robh+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        tglx@...utronix.de, p.zabel@...gutronix.de, linux@...linux.org.uk,
        broonie@...nel.org, arnd@...db.de, stefan.wahren@...e.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        wells.lu@...plus.com
Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver

On Thu, 16 Dec 2021 07:08:10 +0000,
Qin Jian <qinjian@...lus1.com> wrote:
> 
> Add interrupt controller driver for Sunplus SP7021 SoC.
> 
> This is the interrupt controller in P-chip which collects all interrupt
> sources in P-chip and routes them to parent interrupt controller in C-chip.
> 
> Signed-off-by: Qin Jian <qinjian@...lus1.com>
> ---
> Fix the comments from Marc.

No, you didn't.

> +void sp_intc_set_ext(u32 hwirq, int ext_num)
> +{
> +	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
> +}
> +EXPORT_SYMBOL_GPL(sp_intc_set_ext);

I already commented on this. In case it wasn't clear, this is a strong
NAK to random low-level hacks like this.

	M.

-- 
Without deviation from the norm, progress is not possible.