linux-kernel - Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 21:30:01 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

17.12.2021 21:16, Peter Geis пишет:
>>> +                     break;
>>> +             default:
>>> +                     dev_info(&client->dev, "pmic controlled board reset not supported\n");

I'd change this dev_info to dev_dbg to not clutter KMSG.

>> I'd set ret=0 explicitly here. Later on somebody may change the code and
>> ret won't be zero anymore, this is not an uncommon trouble in kernel.
> It took me a moment to see the logic here, but I understand it now.
> 

Could be even better to place the error message simply right after the
register_restart_handler().