linux-kernel - Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdYzYrDp5zcRJ=TudtiAtviJVMyNmqB5TMNYZ=XN+mb3paSTQ@mail.gmail.com>
Date:   Fri, 17 Dec 2021 13:42:29 -0500
From:   Peter Geis <pgwipeout@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx@...il.com> wrote:
>
> 17.12.2021 21:16, Peter Geis пишет:
> >>> +                     break;
> >>> +             default:
> >>> +                     dev_info(&client->dev, "pmic controlled board reset not supported\n");
>
> I'd change this dev_info to dev_dbg to not clutter KMSG.

I'd prefer to leave this as info, since the device is designated as
the system power controller but it is only capable of powering down
the system, not rebooting it.
But on second thought, anyone who's making these changes would be
investigating the driver anyway.
So I'll change it to dev_dbg.

>
> >> I'd set ret=0 explicitly here. Later on somebody may change the code and
> >> ret won't be zero anymore, this is not an uncommon trouble in kernel.
> > It took me a moment to see the logic here, but I understand it now.
> >
>
> Could be even better to place the error message simply right after the
> register_restart_handler().

Good point, thanks