linux-kernel - Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <320d0e55-0202-a7cf-a021-f9a49e0e2f66@arm.com>
Date:   Mon, 20 Dec 2021 11:54:32 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Peter Geis <pgwipeout@...il.com>,
        Dmitry Osipenko <digetx@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Heiko Stuebner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

On 2021-12-17 18:42, Peter Geis wrote:
> On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx@...il.com> wrote:
>>
>> 17.12.2021 21:16, Peter Geis пишет:
>>>>> +                     break;
>>>>> +             default:
>>>>> +                     dev_info(&client->dev, "pmic controlled board reset not supported\n");
>>
>> I'd change this dev_info to dev_dbg to not clutter KMSG.
> 
> I'd prefer to leave this as info, since the device is designated as
> the system power controller but it is only capable of powering down
> the system, not rebooting it.
> But on second thought, anyone who's making these changes would be
> investigating the driver anyway.
> So I'll change it to dev_dbg.

Indeed, this is the expected case for RK808, which has to be 
system-power-controller if you want shutdown to actually power off.

Cheers,
Robin.