linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63ff3ff8-e428-f0f6-eafc-3c517f34cb6c@gmail.com>
Date:   Sat, 18 Dec 2021 23:55:11 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Ismayil Mirzali <ismayilmirzeli@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, simon.fodin@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix styling issues

On 12/18/21 23:36, Ismayil Mirzali wrote:
> Removed extra whitespaces and brackets for oneline if statements
> 
> Signed-off-by: Ismayil Mirzali <ismayilmirzeli@...il.com>
> ---
>   .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    | 20 ++++++++-----------
>   1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7fe3df863fe1..7807b2a6cdc5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -32,7 +32,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
>   	pHalData->SdioTxOQTFreeSpace -= agg_num;
>   
>   	/* if (n > 1) */
> -	/* 	++priv->pshare->nr_out_of_txoqt_space; */
> +	/*	++priv->pshare->nr_out_of_txoqt_space; */
>   

I believe, commented code should be just removed

>   	return true;
>   }

[...]

>   	rtw_unregister_tx_alive(padapter);
> @@ -311,7 +310,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
>   					pxmitframe->pg_num = (txlen + 127) / 128;
>   					pxmitbuf->pg_num += (txlen + 127) / 128;
>   				    /* if (k != 1) */
> -					/* 	((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */
> +					/*	((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */
> 

Same here


With regards,
Pavel Skripkin