linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220105095725.GB7674@kadam>
Date:   Wed, 5 Jan 2022 12:57:25 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ismayil Mirzali <ismayilmirzeli@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        simon.fodin@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix styling issues

On Sat, Dec 18, 2021 at 10:36:47PM +0200, Ismayil Mirzali wrote:
> Removed extra whitespaces and brackets for oneline if statements

s/oneline/one line/.

Do this in two separate patches.

> 
> Signed-off-by: Ismayil Mirzali <ismayilmirzeli@...il.com>
> ---
>  .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    | 20 ++++++++-----------
>  1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 7fe3df863fe1..7807b2a6cdc5 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -32,7 +32,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
>  	pHalData->SdioTxOQTFreeSpace -= agg_num;
>  
>  	/* if (n > 1) */
> -	/* 	++priv->pshare->nr_out_of_txoqt_space; */
> +	/*	++priv->pshare->nr_out_of_txoqt_space; */

Just delete dead code.

>  
>  	return true;
>  }
> @@ -147,13 +147,12 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter)
>  		return _SUCCESS;
>  
>  	ret = rtw_register_tx_alive(padapter);
> -	if (ret != _SUCCESS) {
> +	if (ret != _SUCCESS)
>  		return _SUCCESS;
> -	}
>  
>  	do {
>  		queue_empty = rtl8723_dequeue_writeport(padapter);
> -/* 	dump secondary adapter xmitbuf */
> +		/*	dump secondary adapter xmitbuf */
>  	} while (!queue_empty);
>  
>  	rtw_unregister_tx_alive(padapter);
> @@ -311,7 +310,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
>  					pxmitframe->pg_num = (txlen + 127) / 128;
>  					pxmitbuf->pg_num += (txlen + 127) / 128;
>  				    /* if (k != 1) */
> -					/* 	((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */
> +					/*	((struct xmit_frame*)pxmitbuf->priv_data)->pg_num += pxmitframe->pg_num; */

Delete.

>  					pxmitbuf->ptail += _RND(txlen, 8); /*  round to 8 bytes alignment */
>  					pxmitbuf->len = _RND(pxmitbuf->len, 8) + txlen;
>  				}
> @@ -385,9 +384,8 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padapter)
>  	spin_lock_bh(&pxmitpriv->lock);
>  	ret = rtw_txframes_pending(padapter);
>  	spin_unlock_bh(&pxmitpriv->lock);
> -	if (ret == 0) {
> +	if (ret == 0)
>  		return _SUCCESS;
> -	}
>  
>  	/*  dequeue frame and write to hardware */
>  
> @@ -405,9 +403,8 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padapter)
>  	spin_lock_bh(&pxmitpriv->lock);
>  	ret = rtw_txframes_pending(padapter);
>  	spin_unlock_bh(&pxmitpriv->lock);
> -	if (ret == 1) {
> +	if (ret == 1)
>  		goto next;
> -	}
>  
>  	return _SUCCESS;
>  }
> @@ -428,10 +425,9 @@ int rtl8723bs_xmit_thread(void *context)
>  
>  	do {
>  		ret = rtl8723bs_xmit_handler(padapter);
> -		if (signal_pending(current)) {
> +		if (signal_pending(current))
>  			flush_signals(current);
> -		}
> -	} while (_SUCCESS == ret);
> +	} while (ret == _SUCCESS);

This change was not described in the commit message.

regards,
dan carpenter