linux-kernel - Re: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdYzYoYU-Avi1RK_-gHBWqiWdnxH9Pwa5nnJkU1ZewHm-1OHw@mail.gmail.com>
Date:   Mon, 20 Dec 2021 12:07:12 -0500
From:   Peter Geis <pgwipeout@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Frank Wunderlich <frank-w@...lic-files.de>,
        Lee Jones <lee.jones@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c

On Mon, Dec 20, 2021 at 11:36 AM Dmitry Osipenko <digetx@...il.com> wrote:
>
> 20.12.2021 19:33, Frank Wunderlich пишет:
> > Hi
> >
> >> Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> >> Von: "Peter Geis" <pgwipeout@...il.com>
> >> @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
> >>      if (pm_power_off == rk808_pm_power_off)
> >>              pm_power_off = NULL;
> >>
> >> +    if (of_property_read_bool(np, "rockchip,system-power-controller"))
> >> +            unregister_restart_handler(&rk808_restart_handler);
> >> +
> >>      return 0;
> >>  }
> >
> > this change misses a declaration
> >
> > struct device_node *np = client->dev.of_node;
>
> Good catch, technically the whole of_property_read_bool() could be
> dropped from rk808_remove() since unregister_restart_handler() survives
> if handler wasn't registered.

Thank you all!