linux-kernel - Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcGU6pQqfEPBqjrO@google.com>
Date:   Tue, 21 Dec 2021 08:48:43 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Frank Wunderlich <frank-w@...lic-files.de>
Cc:     Peter Geis <pgwipeout@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Dmitry Osipenko <digetx@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

On Mon, 20 Dec 2021, Frank Wunderlich wrote:

> Hi
> 
> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> > Von: "Peter Geis" <pgwipeout@...il.com>
> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
> >  	if (pm_power_off == rk808_pm_power_off)
> >  		pm_power_off = NULL;
> >
> > +	if (of_property_read_bool(np, "rockchip,system-power-controller"))
> > +		unregister_restart_handler(&rk808_restart_handler);
> > +
> >  	return 0;
> >  }
> 
> this change misses a declaration
> 
> struct device_node *np = client->dev.of_node;

How did this compile when you tested it?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog