linux-kernel - Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1df4cd6c-7f70-4358-e57f-754d98807abe@linux.intel.com>
Date:   Mon, 20 Dec 2021 09:18:29 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Robin Murphy <robin.murphy@....com>, joro@...tes.org,
        will@...nel.org
Cc:     baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org,
        suravee.suthikulpanit@....com, willy@...radead.org,
        linux-kernel@...r.kernel.org, john.garry@...wei.com,
        linux-mm@...ck.org, hch@....de
Subject: Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages_list

Hi Robin,

On 12/17/21 11:31 PM, Robin Murphy wrote:
> From: "Matthew Wilcox (Oracle)"<willy@...radead.org>
> 
> page->freelist is for the use of slab.  We already have the ability
> to free a list of pages in the core mm, but it requires the use of a
> list_head and for the pages to be chained together through page->lru.
> Switch the Intel IOMMU and IOVA code over to using free_pages_list().
> 
> Signed-off-by: Matthew Wilcox (Oracle)<willy@...radead.org>
> [rm: split from original patch, cosmetic tweaks, fix fq entries]
> Signed-off-by: Robin Murphy<robin.murphy@....com>

I had boot tests on my development machines with both strict and lazy
flushing modes. I didn't see any regression, the disk i/o and network
i/o worked good for me.

For changes in iommu/vt-d:

Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>

Best regards,
baolu