linux-kernel - RE: [PATCH v2] locking/rtmutex: Fix incorrect spinning condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5880B86D250D7D92C1E8DD92DA7B9@PH0PR11MB5880.namprd11.prod.outlook.com>
Date:   Mon, 20 Dec 2021 01:45:59 +0000
From:   "Zhang, Qiang1" <qiang1.zhang@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "will@...nel.org" <will@...nel.org>,
        "longman@...hat.com" <longman@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Zhang, Qiang1" <qiang1.zhang@...el.com>
Subject: RE: [PATCH v2] locking/rtmutex: Fix incorrect spinning condition


>Can you please fix your mail client to do proper replies without copying the mail headers into the message?

I have been fix it

>>Though this does not apply because the condition is incomplete. You 
>>somehow dropped this from the condition:
>>
>>                   vcpu_is_preempted(task_cpu(owner)))
>>
>>Please make always sure that your patches apply against Linus tree 
>>before sending them out.
>
> This commit c0bed69daf4b ("locking: Make owner_on_cpu() into 
> <linux/sched.h>") make the following modifications in latest linux-next.
>
> +static inline bool owner_on_cpu(struct task_struct *owner) {
> +       /*
> +        * As lock holder preemption issue, we both skip spinning if
> +        * task is not on cpu or its cpu is preempted
> +        */
> +       return owner->on_cpu && !vcpu_is_preempted(task_cpu(owner));
> +}
> +
>
>Fine, but then please tell against which tree/branch the patch is.

linux-next/master, linux-next/akpm, linux-next/akpm-base.

Thanks,

Zqiang

>
>Thanks,
>
>        tglx