linux-kernel - Re: [PATCH] software node: fix wrong node passed to find nargs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9f5b201-2a00-799d-3a0f-7c9709d77102@gmail.com>
Date:   Mon, 20 Dec 2021 23:37:07 +0000
From:   Daniel Scally <djrscally@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] software node: fix wrong node passed to find nargs_prop

Thanks Andy

On 20/12/2021 22:13, Andy Shevchenko wrote:
> + Sakari, Dan
> 
> On Monday, December 20, 2021, Clément Léger <clement.leger@...tlin.com
> <mailto:clement.leger@...tlin.com>> wrote:
> 
>     nargs_prop refers to a property located in the reference that is found
>     within the nargs property.

I think this is right (it's not used in the ACPI version, and the OF
version is quite convoluted so a bit hard to follow)...but also I note
that none of the users of fwnode_property_get_reference_args() pass
anything to nargs_prop anyway...do we even need this?

Use the correct reference node in call to
>     property_entry_read_int_array() to retrieve the correct nargs value.
> 
>     Fixes: b06184acf751 ("software node: Add
>     software_node_get_reference_args()")

I think this might have been introduced later...maybe 996b0830f95d1,
maybe e933bedd45099

>     Signed-off-by: Clément Léger <clement.leger@...tlin.com
>     <mailto:clement.leger@...tlin.com>>
>     ---
>      drivers/base/swnode.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
>     index 4debcea4fb12..0a482212c7e8 100644
>     --- a/drivers/base/swnode.c
>     +++ b/drivers/base/swnode.c
>     @@ -529,7 +529,7 @@ software_node_get_reference_args(const struct
>     fwnode_handle *fwnode,
>                     return -ENOENT;
> 
>             if (nargs_prop) {
>     -               error =
>     property_entry_read_int_array(swnode->node->properties,
>     +               error =
>     property_entry_read_int_array(ref->node->properties,
>                                                           nargs_prop,
>     sizeof(u32),
>                                                          
>     &nargs_prop_val, 1);
>                     if (error)
>     -- 
>     2.34.1
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>