linux-kernel - Re: [PATCH] usb: dwc3: qcom: Check for null irq pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7974f16-74b1-4d8a-2c28-8acb710d6310@omp.ru>
Date:   Mon, 20 Dec 2021 14:25:42 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <balbi@...nel.org>,
        <gregkh@...uxfoundation.org>, <p.zabel@...gutronix.de>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: qcom: Check for null irq pointer

On 20.12.2021 13:15, Jiasheng Jiang wrote:

> The return value of platform_get_irq() needs to be checked.
> To avoid use of null pointer

   What null pointer, could you please clarify?

in case that there is no irq.
> 
> Fixes: 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
>   drivers/usb/dwc3/dwc3-qcom.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 49e6ca94486d..f04fb3f2fb85 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -614,6 +614,11 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev)
>   		qcom->acpi_pdata->dwc3_core_base_size;
>   
>   	irq = platform_get_irq(pdev_irq, 0);
> +	if (!irq) {

    This is totally wrong! That function returns negative error codes in case 
of failure.

> +		ret = -EINVAL;
> +		goto out;
> +	}
> +
>   	child_res[1].flags = IORESOURCE_IRQ;
>   	child_res[1].start = child_res[1].end = irq;

MBR, Sergey