linux-kernel - Re: [RFC PATCH 1/5] regmap: Add Parity bit Calculation to regmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcCNkCPzhyWm5YE3@sirena.org.uk>
Date:   Mon, 20 Dec 2021 14:05:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     linuxkernel@...utosys.co.uk
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/5] regmap: Add Parity bit Calculation to regmaps

On Fri, Dec 17, 2021 at 10:41:00PM +0000, linuxkernel@...utosys.co.uk wrote:
> From: Christopher Tyerman <c.tyerman@...ebladeautomationsystems.co.uk>
> 
> regmap.h
> 
> Added parity_read_mask to regmap_config
> Added parity_write_mask to regmap_config
> Added (*parity_calc)() to regmap_config
> 
> Added regmap_parity_calc_even() Added regmap_parity_calc_odd()
> 
> internal.h
> 
> Added parity_read_mask to regmap
> Added parity_write_mask to regmap
> Added (*parity_calc) to regmap
> 
> regmap.c
> Altered _regmap_raw_write_impl() to calculate parity
> Altered _regmap_raw_read() to calculate parity
> Added regmap_set_work_buf_parity_mask()
> Added regmap_parity_calc_even()
> Added regmap_parity_calc_odd()
> Added parity_even()
> Added parity16_even(u16 v)
> Added parity32_even(u32 v)
> Added parity64_even(u64 v)

This isn't a good changelog, the changelog needs to describe what is
being changed in the code and why in a way that provides information to
the human reader.  Instead this is essentially a list of code level
changes in the diff.  There's some advice on changelogs in
submitting-patches.rst.  Without a clear changelog it's hard to review
things as it's not clear what the goals are.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)