linux-kernel - AW: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45a433da4f12450f9f890f181bcd4126@emtrion.de>
Date:   Mon, 20 Dec 2021 07:22:05 +0000
From:   "Mueller, Reinhold" <Reinhold.Mueller@...rion.de>
To:     'Fabio Estevam' <festevam@...il.com>
CC:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        "NXP Linux Team" <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion
 emCON-MX8M Mini

Hi Fabio,

thanks for the feedback.
Please see the comments at the marked issues below.
I will send a new patchset.

Regards
Reinhold


Reinhold Mueller
Software engineer


emtrion GmbH
Am Hasenbiel 6 | 76297 Stutensee | Germany

Phone +49 7244 62694 20
Fax +49 7244 62694 19
Email Reinhold.Mueller@...rion.de
Online www.emtrion.de

*** Merry X-Mas & Happy New Year 2022 ***


emtrion GmbH • Amtsgericht Mannheim • HRB 110 300 • Geschäftsführer: Ramona Maurer, Achmed Haddou • Umsatzsteueridentifikationsnummer:DE813694260 • Impressum: www.emtrion.de/de/impressum.html

HINWEIS: Personenbezogene Daten, die Sie per E-Mail an uns übermitteln, werden bei uns gespeichert und verarbeitet. Informationen zu unseren gesetzlichen Informationspflichten, zu uns und unseren Dienstleistungen finden Sie in unseren Datenschutzhinweisen.
Diese E-Mail kann vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und vernichten diese Mail. Das unerlaubte kopieren, sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
> -----Ursprüngliche Nachricht-----
> Von: Fabio Estevam <festevam@...il.com>
> Gesendet: Donnerstag, 16. Dezember 2021 18:19
> An: Mueller, Reinhold <Reinhold.Mueller@...rion.de>
> Cc: Shawn Guo <shawnguo@...nel.org>; Rob Herring
> <robh+dt@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>; Sascha
> Hauer <kernel@...gutronix.de>; NXP Linux Team <linux-imx@....com>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>
> Betreff: Re: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion
> emCON-MX8M Mini
>
> Hi Reinhold,
>
> On Thu, Dec 16, 2021 at 1:59 PM <reinhold.mueller@...rion.com> wrote:
>
> > +       reserved-memory {
> > +               #address-cells = <2>;
> > +               #size-cells = <2>;
> > +               ranges;
> > +
> > +               rpmsg_reserved: rpmsg@...00000 {
> > +                       no-map;
> > +                       reg = <0 0xb8000000 0 0x400000>;
> > +               };
> > +
> > +               loader_reserved: loader@...00000 {
> > +                       no-map;
> > +                       reg = <0 0xbb700000 0x0 0x00100000>;
> > +               };
> > +
> > +               pci_reserved: pci@...00000 {
> > +                       no-map;
> > +                       reg = <0 0xbb800000 0x0 0x00200000>;
> > +               };
> > +
> > +               ivshmem2_reserved: ivshmem2@...00000 {
> > +                       no-map;
> > +                       reg = <0 0xbba00000 0x0 0x00100000>;
> > +               };
> > +
> > +               ivshmem_reserved: ivshmem@...00000 {
> > +                       no-map;
> > +                       reg = <0 0xbbb00000 0x0 0x00100000>;
> > +               };
> > +       };
>
> Are these reserved nodes needed with mainline?
>
> Looks like they are remnants from NXP vendor BSP.
>
The reserved memory nodes are more custom specific, so i remove it from the tree.
> > +&fec1 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_fec1>;
> > +       phy-mode = "rgmii-id";
> > +       phy-reset-gpios = <&gpio1 9 0>;
>
> phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
>
> Actually, phy-reset-gpios is considered deprecated.
>
> You could also add an mdio node as fec child and:
> add reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; there.
Ok, i will add a child in fec fort he reset gpios