linux-kernel - Re: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5C346Om3QS19RQB3EzPu9Ey2b1jt_V_hzOZCk6bEd9wtQ@mail.gmail.com>
Date:   Thu, 16 Dec 2021 14:18:37 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     reinhold.mueller@...rion.com
Cc:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion
 emCON-MX8M Mini

Hi Reinhold,

On Thu, Dec 16, 2021 at 1:59 PM <reinhold.mueller@...rion.com> wrote:

> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               rpmsg_reserved: rpmsg@...00000 {
> +                       no-map;
> +                       reg = <0 0xb8000000 0 0x400000>;
> +               };
> +
> +               loader_reserved: loader@...00000 {
> +                       no-map;
> +                       reg = <0 0xbb700000 0x0 0x00100000>;
> +               };
> +
> +               pci_reserved: pci@...00000 {
> +                       no-map;
> +                       reg = <0 0xbb800000 0x0 0x00200000>;
> +               };
> +
> +               ivshmem2_reserved: ivshmem2@...00000 {
> +                       no-map;
> +                       reg = <0 0xbba00000 0x0 0x00100000>;
> +               };
> +
> +               ivshmem_reserved: ivshmem@...00000 {
> +                       no-map;
> +                       reg = <0 0xbbb00000 0x0 0x00100000>;
> +               };
> +       };

Are these reserved nodes needed with mainline?

Looks like they are remnants from NXP vendor BSP.

> +&fec1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_fec1>;
> +       phy-mode = "rgmii-id";
> +       phy-reset-gpios = <&gpio1 9 0>;

phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;

Actually, phy-reset-gpios is considered deprecated.

You could also add an mdio node as fec child and:
add reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; there.