linux-kernel - Re: [PATCH] init: fix the wrong __setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56d8e86231eec9f46abf9117596ffe07@linux.dev>
Date:   Tue, 21 Dec 2021 02:08:54 +0000
From:   yajun.deng@...ux.dev
To:     "Marco Elver" <elver@...gle.com>
Cc:     keescook@...omium.org, samitolvanen@...gle.com, ojeda@...nel.org,
        masahiroy@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init: fix the wrong __setup_param() definition

December 20, 2021 7:20 PM, "Marco Elver" <elver@...gle.com> wrote:

> On Mon, 20 Dec 2021 at 04:55, Yajun Deng <yajun.deng@...ux.dev> wrote:
> 
>> The parameters in __setup_param() should be four rather than three when
>> MODULE isn't definited.
> 
> This is actually "when MODULE is defined". __setup_param() becomes a
> nop when compiling as a module.
> 
> But that begs the question: why hasn't this been caught before?
> Probably because nobody should be using __setup_param() if something
> can also be compiled as a module, in which case module_param() and
> friends should be used. But perhaps there are valid usecases where i
> t's meant to become a nop if MODULE.
> 
> I don't object this fix, since the !MODULE __setup_param() seems like
> it was meant to be defined.
> 
> Just curious: did you actually encounter a problem with some new code
> using __setup_param()?

NO, it is just code inspection. But for the current code, it's really a bug.
vim drivers/clk/imx/clk.c  +161

#ifndef MODULE

...
__setup_param("earlycon", imx_keep_uart_earlycon,
              imx_keep_uart_clocks_param, 0); 
__setup_param("earlyprintk", imx_keep_uart_earlyprintk,
              imx_keep_uart_clocks_param, 0); 


> 
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
>> ---
>> include/linux/init.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/linux/init.h b/include/linux/init.h
>> index d82b4b2e1d25..62a77850f10e 100644
>> --- a/include/linux/init.h
>> +++ b/include/linux/init.h
>> @@ -355,7 +355,7 @@ void __init parse_early_options(char *cmdline);
>> 
>> #else /* MODULE */
>> 
>> -#define __setup_param(str, unique_id, fn) /* nothing */
>> +#define __setup_param(str, unique_id, fn, early)/* nothing */
>> #define __setup(str, func) /* nothing */
>> #endif
>> 
>> --
>> 2.32.0