linux-kernel - Re: [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Dec 2021 11:11:57 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Hans de Goede <hdegoede@...hat.com>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when
 IRQ can't be retrieved

On 12/17/21 20:28, Andy Shevchenko wrote:
> platform_get_irq() will print a message when it fails.
> No need to repeat this.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: left !irq check untouched (Damien, Sergey)
>  drivers/ata/libahci_platform.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index bfa267e6f045..18296443ccba 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -579,11 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
>  	int i, irq, n_ports, rc;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		if (irq != -EPROBE_DEFER)
> -			dev_err(dev, "no irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>  	if (!irq)
>  		return -EINVAL;
>  

Applied to for-5.17. Thanks !

-- 
Damien Le Moal
Western Digital Research