linux-kernel - Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcF1baxVvP3j8Q/8@kroah.com>
Date:   Tue, 21 Dec 2021 07:34:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     linuxfancy@...glegroups.com,
        Forest Bond <forest@...ttletooquiet.net>,
        Karolina Drobnik <karolinadrobnik@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h

On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following
> checkpatch.pl check:
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> unsigned char byRxMode

No need to line-wrap this.

But this "problem" is not the real thing you are fixing.  The real thing
is the issue that this variable is not needed at all.  Just say that, no
need to justify it with a checkpatch warning, right?

thanks,

greg k-h