linux-kernel - Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Dec 2021 22:52:03 +0100
From:   Tommaso Merciai <tomm.merciai@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linuxfancy@...glegroups.com,
        Forest Bond <forest@...ttletooquiet.net>,
        Karolina Drobnik <karolinadrobnik@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h

On Tue, Dec 21, 2021 at 07:34:21AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following
> > checkpatch.pl check:
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > unsigned char byRxMode
> 
> No need to line-wrap this.
> 
> But this "problem" is not the real thing you are fixing.  The real thing
> is the issue that this variable is not needed at all.  Just say that, no
> need to justify it with a checkpatch warning, right?

Hi Greg,
Thanks for review. I'll fix commit body and resend in v3.

thanks,
tommaso

> 
> thanks,
> 
> greg k-h