linux-kernel - Re: [PATCH v2 1/2] zram: zram_drv: add SPDX license identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b71570d5bc14181c656f8dd7ba69a397fd775495.camel@perches.com>
Date:   Tue, 21 Dec 2021 01:33:00 -0800
From:   Joe Perches <joe@...ches.com>
To:     Miko Larsson <mikoxyzzz@...il.com>, minchan@...nel.org,
        ngupta@...are.org, senozhatsky@...omium.org, axboe@...nel.dk,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Cc:     hch@...radead.org
Subject: Re: [PATCH v2 1/2] zram: zram_drv: add SPDX license identifiers

On Fri, 2021-12-17 at 07:32 +0100, Miko Larsson wrote:
> zram_drv lacks an SPDX license identifier in both its source and in its
> header, so we should add license identifiers based on the copyright info
> provided by the initial comment block.
> 
> Signed-off-by: Miko Larsson <mikoxyzzz@...il.com>
> ---
>  drivers/block/zram/zram_drv.c | 9 ++-------
>  drivers/block/zram/zram_drv.h | 9 ++-------
>  2 files changed, 4 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
[]
> @@ -1,15 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

GPL v2 is a permissive license and this SPDX tag should probably be

// SPDX-License-Identifier: GPL-2.0-or-later or BSD-3-Clause

> +
>  /*
>   * Compressed RAM block device
>   *
>   * Copyright (C) 2008, 2009, 2010  Nitin Gupta
>   *               2012, 2013 Minchan Kim
> - *
> - * This code is released using a dual license strategy: BSD/GPL
> - * You can choose the licence that better fits your requirements.
> - *
> - * Released under the terms of 3-clause BSD License
> - * Released under the terms of GNU General Public License Version 2.0