linux-kernel - Re: [PATCH] dt-bindings: iio: Document "label" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <QRTG4R.GATAOJYEO97C@crapouillou.net>
Date:   Tue, 21 Dec 2021 12:38:14 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Guido Günther <agx@...xcpu.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: Document "label" property



Le mar., déc. 21 2021 at 12:29:04 +0100, Lars-Peter Clausen 
<lars@...afoo.de> a écrit :
> On 12/21/21 11:43 AM, Paul Cercueil wrote:
>> All iio devices can have a label, which will be carried on to 
>> userspace
>> as a sysfs attribute. This is useful when having several iio devices
>> that represent different instances of the same hardware, as the name
>> attribute would then not be enough to differentiate between them.
>> 
>> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>> ---
>>   Documentation/devicetree/bindings/iio/common.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/iio/common.yaml 
>> b/Documentation/devicetree/bindings/iio/common.yaml
>> index f845b41d74c4..a90ad7718ecf 100644
>> --- a/Documentation/devicetree/bindings/iio/common.yaml
>> +++ b/Documentation/devicetree/bindings/iio/common.yaml
>> @@ -32,6 +32,14 @@ properties:
>>         considered 'near' to the device (an object is near to the
>>         sensor).
>>   +  label:
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    description: |
>> +      All iio devices can have a label, which will be carried on to 
>> userspace
>> +      as a sysfs attribute. This is useful when having several iio 
>> devices that
>> +      represent different instances of the same hardware, as the 
>> name attribute
>> +      would then not be enough to differentiate between them.
>> +
> 
> The description has a lot of implementation details of the Linux 
> kernel. The devicetree bindings should be formulated operating system 
> agnostic.
> 
> Something like:
> 
> A descriptive label that allows to uniquely identify the device 
> within the system.

Alright. I'll V2 ASAP.

Cheers,
-Paul