linux-kernel - Re: [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35bca887e697597f7b3e1944b3dd7347c6defca1.camel@linux.intel.com>
Date:   Tue, 21 Dec 2021 16:48:17 -0800
From:   "David E. Box" <david.e.box@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     gregkh@...uxfoundation.org, mustafa.ismail@...el.com,
        shiraz.saleem@...el.com, dledford@...hat.com, leon@...nel.org,
        saeedm@...dia.com, davem@...emloft.net, kuba@...nel.org,
        vkoul@...nel.org, yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, mst@...hat.com,
        jasowang@...hat.com, andriy.shevchenko@...ux.intel.com,
        hdegoede@...hat.com, virtualization@...ts.linux-foundation.org,
        alsa-devel@...a-project.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup

On Tue, 2021-12-21 at 20:09 -0400, Jason Gunthorpe wrote:
> On Tue, Dec 21, 2021 at 03:58:48PM -0800, David E. Box wrote:
> > Depends on "driver core: auxiliary bus: Add driver data helpers" patch [1].
> > Applies the helpers to all auxiliary device drivers using
> > dev_(get/set)_drvdata. Drivers were found using the following search:
> > 
> >     grep -lr "struct auxiliary_device" $(grep -lr "drvdata" .)
> > 
> > Changes were build tested using the following configs:
> > 
> >     vdpa/mlx5:       CONFIG_MLX5_VDPA_NET
> >     net/mlx53:       CONFIG_MLX5_CORE_EN
> >     soundwire/intel: CONFIG_SOUNDWIRE_INTEL
> >     RDAM/irdma:      CONFIG_INFINIBAND_IRDMA
> >                      CONFIG_MLX5_INFINIBAND
> > 
> > [1] https://www.spinics.net/lists/platform-driver-x86/msg29940.html 
> 
> I have to say I don't really find this to be a big readability
> improvement.

I should have referenced the thread [1] discussing the benefit of this change
since the question was asked and answered already. The idea is that drivers
shouldn't have to touch the device API directly if they are already using a
higher level core API (auxiliary bus) that can do that on its behalf.

One benefit of this scheme is that it limits the number of places where changes
need to be made if the device core were to change.

[1] https://lore.kernel.org/all/YbBwOb6JvWkT3JWI@kroah.com/

> 
> Also, what use is 'to_auxiliary_dev()' ? I didn't see any users added..

This was not added by that patch.

Thanks

David
> 
> Jason