linux-kernel - Re: [PATCH] software node: fix wrong node passed to find nargs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 11:34:59 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Daniel Scally <djrscally@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] software node: fix wrong node passed to find nargs_prop

Hi Daniel,

On Tue, Dec 21, 2021 at 10:09:45PM +0000, Daniel Scally wrote:
> Hi Sakari
> 
> On 21/12/2021 09:45, Sakari Ailus wrote:
> > Hi Greg, Andy,
> > 
> > On Tue, Dec 21, 2021 at 10:34:11AM +0100, Greg Kroah-Hartman wrote:
> >> On Mon, Dec 20, 2021 at 11:37:07PM +0000, Daniel Scally wrote:
> >>> Thanks Andy
> >>>
> >>> On 20/12/2021 22:13, Andy Shevchenko wrote:
> >>>> + Sakari, Dan
> >>>>
> >>>> On Monday, December 20, 2021, Clément Léger <clement.leger@...tlin.com
> >>>> <mailto:clement.leger@...tlin.com>> wrote:
> >>>>
> >>>>     nargs_prop refers to a property located in the reference that is found
> >>>>     within the nargs property.
> >>>
> >>> I think this is right (it's not used in the ACPI version, and the OF
> >>> version is quite convoluted so a bit hard to follow)...but also I note
> >>> that none of the users of fwnode_property_get_reference_args() pass
> >>> anything to nargs_prop anyway...do we even need this?
> >>
> >> Looks like it is unused, please just remove it.
> > 
> > If you remove nargs_prop argument, then callers will have to use OF
> > property API instead to parse references with property-defined number of
> > arguments. The goal has been to cover all functionality in a
> > firmware-independent way.
> 
> My mistake, I missed that of_parse_phandle_with_args() has a ton of
> direct users. I guess we should try to replace those with
> fwnode_property_get_reference_args() where appropriate.

I'd say at least when the code is otherwise using fwnode property API.

I guess most of the reference users are OF-based originally while cameras
are perhaps a bit of an exception to this. :-)

-- 
Regards,

Sakari Ailus