linux-kernel - Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 12:53:59 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Frank Wunderlich <frank-w@...lic-files.de>
Cc:     Peter Geis <pgwipeout@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Dmitry Osipenko <digetx@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

On Wed, 22 Dec 2021, Frank Wunderlich wrote:

> > Gesendet: Mittwoch, 22. Dezember 2021 um 12:09 Uhr
> > Von: "Lee Jones" <lee.jones@...aro.org>
> > An: "Frank Wunderlich" <frank-w@...lic-files.de>
> > > Here i have squashed the change in:
> > >
> > > https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f
> > >
> > > With the change i can compile it...
> >
> > Not sure I understand.
> >
> > Please make sure all patches you send for inclusion into the Linux
> > kernel are fully tested.  They should also be bisectable i.e. not
> > depend on patches applied *on top*.
> >
> > > But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely.
> > > regards Frank
> 
> only v1 was sent by me :)
> 
> v4 is compilable and works on rk809 (Bananapi r2 pro)

My comments are directed at whoever sent patches without testing.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog