linux-kernel - Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMdYzYpYumXLEZYNadfHHGZN16ismT2JOMO8bGEegXP69sT3sw@mail.gmail.com>
Date:   Wed, 22 Dec 2021 08:19:57 -0500
From:   Peter Geis <pgwipeout@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Frank Wunderlich <frank-w@...lic-files.de>,
        Robin Murphy <robin.murphy@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c

On Wed, Dec 22, 2021 at 7:54 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> On Wed, 22 Dec 2021, Frank Wunderlich wrote:
>
> > > Gesendet: Mittwoch, 22. Dezember 2021 um 12:09 Uhr
> > > Von: "Lee Jones" <lee.jones@...aro.org>
> > > An: "Frank Wunderlich" <frank-w@...lic-files.de>
> > > > Here i have squashed the change in:
> > > >
> > > > https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f
> > > >
> > > > With the change i can compile it...
> > >
> > > Not sure I understand.
> > >
> > > Please make sure all patches you send for inclusion into the Linux
> > > kernel are fully tested.  They should also be bisectable i.e. not
> > > depend on patches applied *on top*.
> > >
> > > > But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely.
> > > > regards Frank
> >
> > only v1 was sent by me :)
> >
> > v4 is compilable and works on rk809 (Bananapi r2 pro)
>
> My comments are directed at whoever sent patches without testing.

Apologies, due to an unfortunate set of circumstances I missed the
build failed and I was using a stale kernel.

>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog