linux-kernel - Re: [PATCH v2] drivers: net: smc911x: Check for error irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcuXAiLGy7p+2A1839x=9-L=E71xkTaRncx0-Jf2Fh_mg@mail.gmail.com>
Date:   Thu, 23 Dec 2021 14:37:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: net: smc911x: Check for error irq

On Thu, Dec 23, 2021 at 2:33 PM Jiasheng Jiang <jiasheng@...as.ac.cn> wrote:
> On Thursday, December 23, 2021, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > Do other way around.
> > ret = ...
> > if (ret < 0)
> >   ...
> > irq = ret;
>
> This version I correct the patch by using error variable, too.
> And the commit message is as follow.
>
> Because platform_get_irq() could fail and return error irq.
> Therefore, it might be better to check it in order to avoid the use of
> error irq.

Fix commit message and send v3.

-- 
With Best Regards,
Andy Shevchenko