linux-kernel - Re: [PATCH] block: drop needless assignment in set_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211223123724.GA23339@lst.de>
Date:   Thu, 23 Dec 2021 13:37:24 +0100
From:   Christoph Hellwig <hch@....de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Jan Kara <jack@...e.cz>, linux-block@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        llvm@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: drop needless assignment in set_task_ioprio()

>  		if (task->io_context) {
>  			kmem_cache_free(iocontext_cachep, ioc);
> -			ioc = task->io_context;
>  		} else {
>  			task->io_context = ioc;
>  		}

Please also drop the now superflous braces.