lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKXUXMxGcJDiw9ZckCEuv-qiYvTZFh7d6PH5oXG-oS1KknDOew@mail.gmail.com>
Date:   Thu, 23 Dec 2021 13:41:38 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>,
        linux-block@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        llvm@...ts.linux.dev,
        kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: drop needless assignment in set_task_ioprio()

On Thu, Dec 23, 2021 at 1:37 PM Christoph Hellwig <hch@....de> wrote:
>
> >               if (task->io_context) {
> >                       kmem_cache_free(iocontext_cachep, ioc);
> > -                     ioc = task->io_context;
> >               } else {
> >                       task->io_context = ioc;
> >               }
>
> Please also drop the now superflous braces.

Will do. Patch v2 will be there in a second... Lukas

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ