linux-kernel - Re: [PATCH -next] net: phy: micrel: use min() macro instead of doing it manually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30be5b7d-3049-6bb9-9dc2-61b80fed10e0@gmail.com>
Date:   Fri, 24 Dec 2021 10:30:30 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, davem@...emloft.net
Cc:     kuba@...nel.org, andrew@...n.ch, linux@...linux.org.uk,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] net: phy: micrel: use min() macro instead of doing
 it manually

On 24.12.2021 10:12, Yang Li wrote:
> Fix following coccicheck warning:
> ./drivers/net/phy/micrel.c:1482:12-13: WARNING opportunity for min()
> 
Please always check whether a coccicheck warning makes sense,
and don't create "fixes" mechanically w/o thinking.
Here using min() doesn't make sense because it's not about a
numerical operation. ret < 0 is equivalent to is_err(ret).


> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/net/phy/micrel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c6a97fcca0e6..dda426596445 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1479,7 +1479,7 @@ static int ksz886x_cable_test_wait_for_completion(struct phy_device *phydev)
>  				    !(val & KSZ8081_LMD_ENABLE_TEST),
>  				    30000, 100000, true);
>  
> -	return ret < 0 ? ret : 0;
> +	return min(ret, 0);
>  }
>  
>  static int ksz886x_cable_test_one_pair(struct phy_device *phydev, int pair)