linux-kernel - Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc825af2-7331-fa05-26e0-f3054557333a@collabora.com>
Date:   Fri, 24 Dec 2021 10:34:46 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Roger Lu <roger.lu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Enric Balletbo Serra <eballetbo@...il.com>,
        Kevin Hilman <khilman@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Nicolas Boichat <drinkcat@...gle.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Fan Chen <fan.chen@...iatek.com>,
        HenryC Chen <HenryC.Chen@...iatek.com>,
        YT Lee <yt.lee@...iatek.com>,
        Xiaoqing Liu <Xiaoqing.Liu@...iatek.com>,
        Charles Yang <Charles.Yang@...iatek.com>,
        Angus Lin <Angus.Lin@...iatek.com>,
        Mark Rutland <mark.rutland@....com>,
        Nishanth Menon <nm@...com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine

Il 24/12/21 10:27, Roger Lu ha scritto:
> Hi AngeloGioacchino,
> 
> Sorry for the late reply and thanks for all the advices.
> 
> On Thu, 2021-10-21 at 10:46 +0200, AngeloGioacchino Del Regno wrote:
>> Il 28/04/21 08:54, Roger Lu ha scritto:
>>> The Smart Voltage Scaling(SVS) engine is a piece of hardware
>>> which calculates suitable SVS bank voltages to OPP voltage table.
>>> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
>>> when receiving OPP_EVENT_ADJUST_VOLTAGE.
>>>
>>> Signed-off-by: Roger Lu <roger.lu@...iatek.com>
>>> ---
>>>    drivers/soc/mediatek/Kconfig   |   10 +
>>>    drivers/soc/mediatek/Makefile  |    1 +
>>>    drivers/soc/mediatek/mtk-svs.c | 1723 ++++++++++++++++++++++++++++++++
>>>    3 files changed, 1734 insertions(+)
>>>    create mode 100644 drivers/soc/mediatek/mtk-svs.c
> 
> [snip]
> 
>>> +/* svs bank common setting */
>>> +#define SVSB_DET_CLK_EN			BIT(31)
>>> +#define SVSB_TZONE_HIGH_TEMP_MAX	U32_MAX
>>> +#define SVSB_RUNCONFIG_DEFAULT		0x80000000
>>> +#define SVSB_DC_SIGNED_BIT		0x8000
>>> +#define SVSB_INTEN_INIT0x		0x00005f01
>>> +#define SVSB_INTEN_MONVOPEN		0x00ff0000
>>> +#define SVSB_EN_OFF			0x0
>>> +#define SVSB_EN_MASK			0x7
>>> +#define SVSB_EN_INIT01			0x1
>>> +#define SVSB_EN_INIT02			0x5
>>> +#define SVSB_EN_MON			0x2
>>> +#define SVSB_INTSTS_MONVOP		0x00ff0000
>>> +#define SVSB_INTSTS_COMPLETE		0x1
>>> +#define SVSB_INTSTS_CLEAN		0x00ffffff
>>> +
>>> +static DEFINE_SPINLOCK(mtk_svs_lock);
>>> +
>>> +/*
>>
>> Thanks for using kernel-doc!! However, to be proper, this has to be
>> /**
>>    * ..........
> 
> Oh okay. Thanks. I will use /** to add multi-line comments. However, I checked
> kernel doc-guide and it uses indent as below. So, I'll follow it. If I'm doing
> it wrong, please correct me. Thanks a lot.
> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
> 
> /**
>   * .........
> 

You're welcome! By the way, yes, the indentation is as shown on the documentation.

Regards,
- Angelo