linux-kernel - [PATCH] Module Name: drivers/nfc/pn544/pn544.c fix a bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211225132728.25111-1-hongqiang601217@gmail.com>
Date:   Sat, 25 Dec 2021 21:27:28 +0800
From:   hrshy0629 <hongqiang601217@...il.com>
To:     krzysztof.kozlowski@...onical.com, davem@...emloft.net
Cc:     kuba@...nel.org, linux-kernel@...r.kernel.org,
        hrshy0629 <hongqiang601217@...il.com>
Subject: [PATCH] Module Name: drivers/nfc/pn544/pn544.c    fix a bug

    I noticed that the same usage for API nfc_hci_send_cmd() in line 541 and line 552 of the file pn544.c.
    And the variable r is checked on line 545 but not checked on line 552.
    The r in line 552 should be checked.

Signed-off-by: hrshy0629 <hongqiang601217@...il.com>
---
 drivers/nfc/pn544/pn544.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nfc/pn544/pn544.c b/drivers/nfc/pn544/pn544.c
index 32a61a185142..531eda0d11a2 100644
--- a/drivers/nfc/pn544/pn544.c
+++ b/drivers/nfc/pn544/pn544.c
@@ -552,6 +552,8 @@ static int pn544_hci_complete_target_discovered(struct nfc_hci_dev *hdev,
 			r = nfc_hci_send_cmd(hdev, PN544_RF_READER_F_GATE,
 					     PN544_RF_READER_CMD_ACTIVATE_NEXT,
 					     uid_skb->data, uid_skb->len, NULL);
+			if (r < 0)
+				return r;
 			kfree_skb(uid_skb);
 		}
 	} else if (target->supported_protocols & NFC_PROTO_ISO14443_MASK) {
-- 
2.17.1