linux-kernel - Re: [PATCH v2 02/23] PCI: artpec6: Prefer of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Dec 2021 14:30:57 +0100
From:   Jesper Nilsson <Jesper.Nilsson@...s.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Fan Fei <ffclaire1224@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jesper Nilsson <Jesper.Nilsson@...s.com>,
        linux-arm-kernel <linux-arm-kernel@...s.com>
Subject: Re: [PATCH v2 02/23] PCI: artpec6: Prefer of_device_get_match_data()

On Thu, Dec 23, 2021 at 02:10:33AM +0100, Bjorn Helgaas wrote:
> From: Fan Fei <ffclaire1224@...il.com>
> 
> The artpec6 driver only needs the device data, not the whole struct
> of_device_id.  Use of_device_get_match_data() instead of of_match_device().
> No functional change intended.
> 
> [bhelgaas: commit log]
> Signed-off-by: Fan Fei <ffclaire1224@...il.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Looks good to me,

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> Cc: linux-arm-kernel@...s.com

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com