[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211225025115.475348-1-yangyingliang@huawei.com>
Date: Sat, 25 Dec 2021 10:51:15 +0800
From: Yang Yingliang <yangyingliang@...wei.com>
To: <linux-kernel@...r.kernel.org>, <live-patching@...r.kernel.org>
CC: <jpoimboe@...hat.com>, <jikos@...nel.org>, <mbenes@...e.cz>,
<pmladek@...e.com>, <void@...ifault.com>
Subject: [PATCH -next] livepatch: Fix missing unlock on error in klp_enable_patch()
Add missing unlock when try_module_get() fails in klp_enable_patch().
Fixes: bf01c2975925 ("livepatch: Fix kobject refcount bug on klp_init_patch_early failure path")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
kernel/livepatch/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 23cf444091a8..01bfab7fe7c0 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -1047,8 +1047,10 @@ int klp_enable_patch(struct klp_patch *patch)
return -EINVAL;
}
- if (!try_module_get(patch->mod))
+ if (!try_module_get(patch->mod)) {
+ mutex_unlock(&klp_mutex);
return -ENODEV;
+ }
klp_init_patch_early(patch);
--
2.25.1
Powered by blists - more mailing lists