[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YcnqcXMQ7hxBe68a@dev0025.ash9.facebook.com>
Date: Mon, 27 Dec 2021 08:31:45 -0800
From: David Vernet <void@...ifault.com>
To: Yang Yingliang <yangyingliang@...wei.com>
Cc: linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
jpoimboe@...hat.com, jikos@...nel.org, mbenes@...e.cz,
pmladek@...e.com
Subject: Re: [PATCH -next] livepatch: Fix missing unlock on error in
klp_enable_patch()
Yang Yingliang <yangyingliang@...wei.com> wrote on Sat [2021-Dec-25 10:51:15 +0800]:
> Add missing unlock when try_module_get() fails in klp_enable_patch().
>
> Fixes: bf01c2975925 ("livepatch: Fix kobject refcount bug on klp_init_patch_early failure path")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> kernel/livepatch/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 23cf444091a8..01bfab7fe7c0 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -1047,8 +1047,10 @@ int klp_enable_patch(struct klp_patch *patch)
> return -EINVAL;
> }
>
> - if (!try_module_get(patch->mod))
> + if (!try_module_get(patch->mod)) {
> + mutex_unlock(&klp_mutex);
> return -ENODEV;
> + }
>
> klp_init_patch_early(patch);
>
> --
> 2.25.1
>
Apologies for the silly oversight. Thank you for the fix.
Acked-by: David Vernet <void@...ifault.com>
Powered by blists - more mailing lists