linux-kernel - Re: [PATCH] ocfs2: remove redundant assignment to pointer root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f88a34a6-abe8-69e2-33e0-350a0a76eea7@linux.alibaba.com>
Date:   Tue, 28 Dec 2021 09:49:49 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Mark Fasheh <mark@...heh.com>,
        Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
        akpm <akpm@...ux-foundation.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: remove redundant assignment to pointer root_bh



On 12/28/21 9:37 AM, Colin Ian King wrote:
> Pointer root_bh is being initialized with a value that is not read,
> it is being re-assigned later on closer to its use. The early
> initialization is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index bb247bc349e4..bf9357123bc5 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -2040,7 +2040,7 @@ static void ocfs2_complete_edge_insert(handle_t *handle,
>  	int i, idx;
>  	struct ocfs2_extent_list *el, *left_el, *right_el;
>  	struct ocfs2_extent_rec *left_rec, *right_rec;
> -	struct buffer_head *root_bh = left_path->p_node[subtree_index].bh;
> +	struct buffer_head *root_bh;
>  
>  	/*
>  	 * Update the counts and position values within all the