linux-kernel - Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ycq40KwY8SxUslXC@google.com>
Date:   Tue, 28 Dec 2021 15:12:16 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Trevor Wu <trevor.wu@...iatek.com>
Cc:     broonie@...nel.org, tiwai@...e.com, robh+dt@...nel.org,
        matthias.bgg@...il.com, alsa-devel@...a-project.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, jiaxin.yu@...iatek.com,
        shumingf@...ltek.com
Subject: Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682
 series

On Tue, Dec 28, 2021 at 02:48:21PM +0800, Trevor Wu wrote:
> Playback pop is observed and the root cause is the reference clock
> provided by MT8195 is diabled before RT5682 finishes the control flow.
> 
> To ensure the reference clock supplied to RT5682 is disabled after RT5682
> finishes all register controls. We replace BCLK with MCLK for RT5682
> reference clock, and makes use of set_bias_level_post to handle MCLK
> which guarantees MCLK is off after all RT5682 register access.
> 
> Signed-off-by: Trevor Wu <trevor.wu@...iatek.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@...gle.com>