lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Dec 2021 21:58:51 -0500 From: Arnd Bergmann <arnd@...nel.org> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Niklas Schnelle <schnelle@...ux.ibm.com>, Bjorn Helgaas <bhelgaas@...gle.com>, John Garry <john.garry@...wei.com>, Nick Hu <nickhu@...estech.com>, Greentime Hu <green.hu@...il.com>, Vincent Chen <deanbo422@...il.com>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Guo Ren <guoren@...nel.org>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux-Arch <linux-arch@...r.kernel.org>, linux-pci <linux-pci@...r.kernel.org>, linux-riscv <linux-riscv@...ts.infradead.org>, linux-csky@...r.kernel.org Subject: Re: [RFC 04/32] parport: PC style parport depends on HAS_IOPORT On Tue, Dec 28, 2021 at 5:14 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote: > > Hi Niklas, > > On Mon, Dec 27, 2021 at 5:48 PM Niklas Schnelle <schnelle@...ux.ibm.com> wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > not being declared. As PC style parport uses these functions we need to > > handle this dependency for HAS_IOPORT. > > > > Co-developed-by: Arnd Bergmann <arnd@...nel.org> > > Signed-off-by: Arnd Bergmann <arnd@...nel.org> > > Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com> > > Thanks for your patch! > > > --- a/drivers/parport/Kconfig > > +++ b/drivers/parport/Kconfig > > @@ -14,7 +14,6 @@ config ARCH_MIGHT_HAVE_PC_PARPORT > > > > menuconfig PARPORT > > tristate "Parallel port support" > > - depends on HAS_IOMEM > > Why drop this? > Don't all other parport drivers depend on it? The other drivers all have dependencies on specific platforms, so I probably dropped it in the original draft because the remaining dependencies are sufficient. Technically, the partport_pc driver only needs HAS_IOPORT, not HAS_IOMEM, but in the end this makes very little difference. Arnd
Powered by blists - more mailing lists