linux-kernel - Re: [PATCH] lib/mpi: add the return value check of kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7817afe-b1ed-0967-5a57-0a6bdf2aec4e@linux.alibaba.com>
Date:   Thu, 30 Dec 2021 14:41:55 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Zizhuang Deng <sunsetdzz@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/mpi: add the return value check of kcalloc

Hi Zizhuang,

On 12/30/21 10:51 AM, Zizhuang Deng wrote:
> Add the return value check of kcalloc to avoid potential
> NULL ptr dereference.
> 
> Signed-off-by: Zizhuang Deng <sunsetdzz@...il.com>
> ---
>   lib/mpi/mpi-mod.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..6fd6900f0798 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>   	mpi_normalize(m);
>   	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
>   

Remove this empty line.

> +	if (!ctx) {
> +		return NULL;
> +	}
> +
>   	if (copy) {
>   		ctx->m = mpi_copy(m);
>   		ctx->m_copied = 1;


Thanks for pointing it out. Please send a copy to linux-crypto and 
Herbert Xu.

Best regards,
Tianjia