linux-kernel - [PATCH] lib/mpi: add the return value check of kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 10:51:59 +0800
From:   Zizhuang Deng <sunsetdzz@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     tianjia.zhang@...ux.alibaba.com,
        Zizhuang Deng <sunsetdzz@...il.com>
Subject: [PATCH] lib/mpi: add the return value check of kcalloc

Add the return value check of kcalloc to avoid potential
NULL ptr dereference.

Signed-off-by: Zizhuang Deng <sunsetdzz@...il.com>
---
 lib/mpi/mpi-mod.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..6fd6900f0798 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
 	mpi_normalize(m);
 	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
 
+	if (!ctx) {
+		return NULL;
+	}
+
 	if (copy) {
 		ctx->m = mpi_copy(m);
 		ctx->m_copied = 1;
-- 
2.25.1