linux-kernel - Re: [PATCH] clk: qcom: gcc-msm8994: Remove NoC clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 17:42:29 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-msm8994: Remove NoC clocks

On Thu, 30 Dec 2021 at 17:29, Konrad Dybcio
<konrad.dybcio@...ainline.org> wrote:
>
>
> > You don't have to init array entries with NULL values (if it's not for
> > the documentation purposes). Uninitialized entries will get NULL value
> > anyway.
> >


> Forgot to address this in my previous message, but I think it may be a
>
> good indicator for the next person that decides this would be a good idea
>
> that they should probably stay away from it.. If it's really bad, then sure, I
>
> can remove it..

You can add a comment on top of those assignments telling this, so
that the next person doing the semi-auto cleanup wouldn't delete the
assignments.

-- 
With best wishes
Dmitry