linux-kernel - Re: [PATCH v2] staging: pi433: add comment to rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211230145621.GA3236@localhost.localdomain>
Date:   Fri, 31 Dec 2021 03:56:21 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     realwakka@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: pi433: add comment to rx_lock mutex
 definition

On Thu, Dec 30, 2021 at 11:56:33AM +0100, Greg KH wrote:
> On Thu, Dec 23, 2021 at 10:56:15AM +1300, Paulo Miguel Almeida wrote:
> > +	/*
> > +	 * rx_lock is used to avoid race-conditions that can be triggered from userspace.
> > +	 *
> > +	 * For instance, if a program in userspace is reading the char device
> > +	 * allocated in this module then another program won't be able to change RX
> > +	 * configuration of the RF69 hardware module via ioctl and vice versa.
> > +	 *
> > +	 * utilization summary:
> > +	 *  - pi433_read: blocks are read until rx read something (up to the buffer size)
> > +	 *  - pi433_ioctl: during pending read request, change of config not allowed
> > +	 */
> 
> This is nice, but way too specific, and will quickly get out-of-date.
> 
> How about something simple like:
> 	/* Protects all rx_* variable accesses */
> 
I see your point. I will send a new version of this patch with your
sugestion. Thanks for guidance.

thanks,

Paulo A.