linux-kernel - Re: [PATCH v3 00/23] counter: cleanups and device lifetime fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Dec 2021 16:08:28 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Kamel Bouhara <kamel.bouhara@...tlin.com>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        David Lechner <david@...hnology.com>,
        Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        linux-kernel@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        kernel@...gutronix.de,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Syed Nayyar Waris <syednwaris@...il.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Patrick Havelange <patrick.havelange@...ensium.com>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 00/23] counter: cleanups and device lifetime fixes

On Thu, Dec 30, 2021 at 02:58:26PM +0000, Jonathan Cameron wrote:
> On Thu, 30 Dec 2021 09:53:51 +0100
> Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> 
> > Hello,
> > 
> > On Wed, Dec 29, 2021 at 04:44:18PM +0100, Uwe Kleine-König wrote:
> > > this is v3 of my series to fix device lifetime issues in the counter
> > > framework. This hopefully addresses all things pointed out for v2.
> > > 
> > > Note this depends on 60f07e74f86b (which is in next) now. Full diffstat
> > > below.
> > > 
> > > Things that could be further improved:
> > > 
> > > [...]
> > > 
> > > Uwe Kleine-König (23):
> > >   counter: Use container_of instead of drvdata to track counter_device
> > >   counter: ftm-quaddec: Drop unused platform_set_drvdata()
> > >   counter: microchip-tcb-capture: Drop unused platform_set_drvdata()
> > >   counter: Provide a wrapper to access device private data
> > >   counter: 104-quad-8: Convert to counter_priv() wrapper
> > >   counter: interrupt-cnt: Convert to counter_priv() wrapper
> > >   counter: microchip-tcb-capture: Convert to counter_priv() wrapper
> > >   counter: intel-qep: Convert to counter_priv() wrapper
> > >   counter: ftm-quaddec: Convert to counter_priv() wrapper
> > >   counter: ti-eqep: Convert to counter_priv() wrapper
> > >   counter: stm32-lptimer-cnt: Convert to counter_priv() wrapper
> > >   counter: stm32-timer-cnt: Convert to counter_priv() wrapper
> > >   counter: Provide alternative counter registration functions
> > >   counter: Update documentation for new counter registration functions
> > >   counter: 104-quad-8: Convert to new counter registration
> > >   counter: interrupt-cnt: Convert to new counter registration
> > >   counter: intel-qep: Convert to new counter registration
> > >   counter: ftm-quaddec: Convert to new counter registration
> > >   counter: microchip-tcb-capture: Convert to new counter registration
> > >   counter: stm32-timer-cnt: Convert to new counter registration
> > >   counter: stm32-lptimer-cnt: Convert to new counter registration
> > >   counter: ti-eqep: Convert to new counter registration
> > >   counter: remove old and now unused registration API
> > > 
> > >  Documentation/driver-api/generic-counter.rst |  10 +-
> > >  drivers/counter/104-quad-8.c                 |  93 +++++-----
> > >  drivers/counter/counter-core.c               | 186 ++++++++++++++-----
> > >  drivers/counter/ftm-quaddec.c                |  36 ++--
> > >  drivers/counter/intel-qep.c                  |  46 ++---
> > >  drivers/counter/interrupt-cnt.c              |  38 ++--
> > >  drivers/counter/microchip-tcb-capture.c      |  44 ++---
> > >  drivers/counter/stm32-lptimer-cnt.c          |  51 ++---
> > >  drivers/counter/stm32-timer-cnt.c            |  48 ++---
> > >  drivers/counter/ti-eqep.c                    |  31 ++--
> > >  include/linux/counter.h                      |  15 +-
> > >  11 files changed, 356 insertions(+), 242 deletions(-)
> > > 
> > > Range-diff against v2:
> > > [...]
> > > 
> > > base-commit: a7904a538933c525096ca2ccde1e60d0ee62c08e
> > > prerequisite-patch-id: 9459ad8bc78190558df9123f8bebe28ca1c396ea  
> > 
> > All patches have a blessing by at least one of William and Jonathan.
> 
> For future reference (may be fine this time) William has final say on counter
> stuff as the maintainer so treat my input as just another set of eyes.

Yeah, right. William only didn't ack patch 13 but wrote in reply it in v2:

	I agree with the approach taken in this patch, and I don't have much to
	add after the suggestions Lars-Peter and Jonathan have already given. So
	assuming those are addressed in the next version I expect to Ack this
	patch as well.

So I assume it's just that William didn't have the time yet to look into
v3 (or v4 that I just sent out) yet.

Best regards and thanks to all who gave feedback to improve this patch
set,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)