linux-kernel - [PATCH] lib/oid_registry.c: remove redundant assignment to variable num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211230150903.190860-1-colin.i.king@gmail.com>
Date:   Thu, 30 Dec 2021 15:09:03 +0000
From:   Colin Ian King <colin.i.king@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Stefan Berger <stefanb@...ux.ibm.com>
Cc:     kernel-janitors@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: [PATCH] lib/oid_registry.c: remove redundant assignment to variable num

The variable num is being assigned a value that is never read, it
is being re-assigned a value in both paths of the following if
statement. The assignment is redundant and can be removed.

Cleans up clang-scan warning:
lib/oid_registry.c:149:3: warning: Value stored to 'num' is never
read [deadcode.DeadStores]
                num = 0;

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 lib/oid_registry.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/oid_registry.c b/lib/oid_registry.c
index e592d48b1974..fe6705cfd780 100644
--- a/lib/oid_registry.c
+++ b/lib/oid_registry.c
@@ -146,7 +146,6 @@ int sprint_oid(const void *data, size_t datasize, char *buffer, size_t bufsize)
 	bufsize -= count;
 
 	while (v < end) {
-		num = 0;
 		n = *v++;
 		if (!(n & 0x80)) {
 			num = n;
-- 
2.33.1