linux-kernel - Re: [PATCH] ACPI: battery: Add the ThinkPad "Not Charging" quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jdJNh4QB=-=TCKPZNYnvREPKor+mMyyUZZP8GBMn-ZFQ@mail.gmail.com>
Date:   Thu, 30 Dec 2021 17:29:33 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Hans de Goede <hdegoede@...hat.com>,
        Thomas Weißschuh <linux@...ssschuh.net>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ibm-acpi-devel@...ts.sourceforge.net,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Mark Pearson <markpearson@...ovo.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Ognjen Galic <smclt30p@...il.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Bastien Nocera <hadess@...ess.net>,
        David Zeuthen <davidz@...hat.com>,
        Richard Hughes <richard@...hsie.com>
Subject: Re: [PATCH] ACPI: battery: Add the ThinkPad "Not Charging" quirk

On Thu, Dec 23, 2021 at 5:36 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi Thomas,
>
> On 12/22/21 22:20, Thomas Weißschuh wrote:
> > The EC/ACPI firmware on Lenovo ThinkPads used to report a status
> > of "Unknown" when the battery is between the charge start and
> > charge stop thresholds. On Windows, it reports "Not Charging"
> > so the quirk has been added to also report correctly.
> >
> > Now the "status" attribute returns "Not Charging" when the
> > battery on ThinkPads is not physicaly charging.
> >
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
>
> Thanks, patch looks good to me.
>
> As for the userspace issues in dealing with the
> POWER_SUPPLY_STATUS_NOT_CHARGING status, those indeed
> have long been fixed and this status is already returned
> acpi//battery.c from the acpi_battery_handle_discharging()
> function for a while no; and we have had no complaints
> about that:
>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Applied as 5.17 material, thanks!