linux-kernel - Re: [PATCH] android: use "menuconfig" menu entry type for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yc3lLpYKXl0MAEoO@kroah.com>
Date:   Thu, 30 Dec 2021 17:58:22 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jan Engelhardt <jengelh@...i.de>
Cc:     linux-kernel@...r.kernel.org, tkjos@...roid.com
Subject: Re: [PATCH] android: use "menuconfig" menu entry type for
 CONFIG_ANDROID

On Thu, Dec 30, 2021 at 03:50:02PM +0100, Jan Engelhardt wrote:
> Allow disabling the Android driver section from within the Device
> Drivers submenu, without having to descend into the Android drivers
> submenu first.
> 
> Signed-off-by: Jan Engelhardt <jengelh@...i.de>
> ---
>  drivers/android/Kconfig | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index 53b22e26266c..dc0a373ab879 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -1,7 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -menu "Android"
> -
> -config ANDROID
> +menuconfig ANDROID
>  	bool "Android Drivers"
>  	help
>  	  Enable support for various drivers needed on the Android platform
> @@ -55,5 +53,3 @@ config ANDROID_BINDER_IPC_SELFTEST
>  	  alignments.
>  
>  endif # if ANDROID
> -
> -endmenu
> -- 
> 2.34.1
> 

But, when you do this, you loose these lines from the .config file,
resulting in this diff in the file:

--- .config.save	2021-12-30 17:54:49.327896243 +0100
+++ .config	2021-12-30 17:56:21.459819436 +0100
@@ -6477,17 +6477,11 @@
 CONFIG_RAS=y
 # CONFIG_RAS_CEC is not set
 # CONFIG_USB4 is not set
-
-#
-# Android
-#
 CONFIG_ANDROID=y
 CONFIG_ANDROID_BINDER_IPC=y
 CONFIG_ANDROID_BINDERFS=y
 CONFIG_ANDROID_BINDER_DEVICES="binder"
 CONFIG_ANDROID_BINDER_IPC_SELFTEST=y
-# end of Android
-
 # CONFIG_LIBNVDIMM is not set
 CONFIG_DAX=m
 CONFIG_NVMEM=y



Is that really a good idea?  What's the default these days?

Also, to be pedantic, this is a [v2] patch, right?  :)

I'll wait for the other Android driver maintainers to review this before
applying it, if they agree it is ok to do.

thanks,

greg k-h