linux-kernel - Re: [PATCH] iio: stm: don't always auto-enable I2C and SPI interface drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0zH1Xpx6qKNOpQN-po=fisAikAai_7X+2+f9zUDjFLLw@mail.gmail.com>
Date:   Sun, 2 Jan 2022 08:49:58 -0500
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        Cai Huoqing <caihuoqing@...du.com>, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: stm: don't always auto-enable I2C and SPI interface drivers

On Sun, Jan 2, 2022 at 2:02 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Wed, Dec 29, 2021 at 8:29 AM Nikita Yushchenko
> <nikita.yoush@...entembedded.com> wrote:
>
> >  config IIO_ST_ACCEL_I2C_3AXIS
> > -       tristate
> > -       depends on IIO_ST_ACCEL_3AXIS
> > -       depends on IIO_ST_SENSORS_I2C
> > +       tristate "STMicroelectronics accelerometers 3-Axis I2C Interface"
> > +       depends on (I2C && IIO_ST_ACCEL_3AXIS)
> > +       default y if (I2C && IIO_ST_ACCEL_3AXIS)
> > +       select IIO_ST_SENSORS_I2C
>
> This thing that a Kconfig symbol is made to depend on itself just
> boggles my head but it wouldn't surprise me if KConfig is this weird :(
>
> I CCed Arnd who knows KConfig a bit better than anyone I know.

It looks fine to me, the only thing I'd change is to write the default as

           default I2C && IIO_ST_SENSORS_I2C

rather than 'default y', which is less intuitive for the case where one
of the dependencies is =m.

      Arnd