linux-kernel - Re: [PATCH] iio: stm: don't always auto-enable I2C and SPI interface drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f233def-99c8-d6f1-b4e6-26cc21187a01@cogentembedded.com>
Date:   Sun, 2 Jan 2022 13:59:56 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        Cai Huoqing <caihuoqing@...du.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: stm: don't always auto-enable I2C and SPI interface
 drivers



02.01.2022 10:02, Linus Walleij wrote:
> On Wed, Dec 29, 2021 at 8:29 AM Nikita Yushchenko
> <nikita.yoush@...entembedded.com> wrote:
> 
>>   config IIO_ST_ACCEL_I2C_3AXIS
>> -       tristate
>> -       depends on IIO_ST_ACCEL_3AXIS
>> -       depends on IIO_ST_SENSORS_I2C
>> +       tristate "STMicroelectronics accelerometers 3-Axis I2C Interface"
>> +       depends on (I2C && IIO_ST_ACCEL_3AXIS)
>> +       default y if (I2C && IIO_ST_ACCEL_3AXIS)
>> +       select IIO_ST_SENSORS_I2C
> 
> This thing that a Kconfig symbol is made to depend on itself just
> boggles my head but it wouldn't surprise me if KConfig is this weird :(
> 
> I CCed Arnd who knows KConfig a bit better than anyone I know.

Sorry but I don't see a dependency on itself here.

"IIO_ST_ACCEL_I2C_3AXIS" depends on "IIO_ST_ACCEL_3AXIS"

Name with I2C embedded not at end could be a bit wired, but in this patch I don't change any names to 
keep things 100% backward-compatible.

Nikita