linux-kernel - Re: [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdHbo6YXFmI+UQJh@martin-debian-1.paytec.ch>
Date:   Sun, 2 Jan 2022 18:06:43 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but
 never used

Thus wrote Michael Straube (straube.linux@...il.com):

> The field UsbRxHighSpeedMode of struct hal_data_8188e is set but
> never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> v3: no changes
> v2: no changes

>  drivers/staging/r8188eu/hal/usb_halinit.c      | 5 -----
>  drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
>  2 files changed, 8 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 104705ef170e..96db9a8e7667 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -502,16 +502,11 @@ usb_AggSettingRxUpdate(

>  static void InitUsbAggregationSetting(struct adapter *Adapter)
>  {
> -	struct hal_data_8188e *haldata = &Adapter->haldata;
> -
>  	/*  Tx aggregation setting */
>  	usb_AggSettingTxUpdate(Adapter);

>  	/*  Rx aggregation setting */
>  	usb_AggSettingRxUpdate(Adapter);
> -
> -	/*  201/12/10 MH Add for USB agg mode dynamic switch. */
> -	haldata->UsbRxHighSpeedMode = false;
>  }

>  static void _InitOperationMode(struct adapter *Adapter)
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index e8cb093abb62..8b54f52f49e2 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -262,9 +262,6 @@ struct hal_data_8188e {
>  	u8	OutEpQueueSel;
>  	u8	OutEpNumber;

> -	/*  Add for USB aggreation mode dynamic shceme. */
> -	bool		UsbRxHighSpeedMode;
> -
>  	/*  2010/11/22 MH Add for slim combo debug mode selective. */
>  	/*  This is used for fix the drawback of CU TSMC-A/UMC-A cut.
>  	 * HW auto suspend ability. Close BT clock. */
> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@...ser.cx>